Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI ONLY Upgrade to Scala 2.13.0-M4 #3344

Closed
wants to merge 1 commit into from

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented Apr 17, 2018

Continuation of #3344.

  • library
  • javalib
  • scalalib
  • compiler
  • testSuite
  • scalaTestSuite
  • linker
  • ir
  • partest
  • upgrade to latest Scala (a few things have been fixed upstream, and that will impact Scala.js)
  • squash commits

@julienrf julienrf force-pushed the scala-2.13.0-M4-squashed branch 4 times, most recently from ccdc040 to d188957 Compare April 24, 2018 08:28
@julienrf julienrf changed the title [ci only] squashed scala-2.13.0-M4 Upgrade to Scala 2.13.0-M4 Apr 25, 2018
@julienrf julienrf mentioned this pull request Apr 25, 2018
11 tasks
@julienrf julienrf force-pushed the scala-2.13.0-M4-squashed branch 2 times, most recently from 0364ffd to b0068b5 Compare April 26, 2018 13:51
@julienrf
Copy link
Contributor Author

julienrf commented Apr 26, 2018

I’ve updated the PR to use the latest Scala version to date (2.13.0-pre-91a7d72). I expect that after #3353 is merged the CI should run again but two tests are still expected to fail:

@sjrd
Copy link
Member

sjrd commented Apr 26, 2018

I merged #3353. If you still get a chance to rebase this PR on top of the latest 0.6.x before you go on vacation, it would probably make the PR close to being green again. Otherwise I'll eventually do it myself.

@sjrd
Copy link
Member

sjrd commented May 10, 2018

Rebased on top of #3359 and upgraded to the latest nightly of Scala.

@sjrd sjrd force-pushed the scala-2.13.0-M4-squashed branch 8 times, most recently from 28232c2 to 2fa36d4 Compare May 14, 2018 09:59
@sjrd
Copy link
Member

sjrd commented May 14, 2018

Rebased on #3361 to validate that only changing the build, tools and CI scripts on top of #3361 is enough to get the CI passing with 2.13.0-M4.

@sjrd sjrd changed the title Upgrade to Scala 2.13.0-M4 CI ONLY Upgrade to Scala 2.13.0-M4 May 14, 2018
@sjrd sjrd force-pushed the scala-2.13.0-M4-squashed branch 2 times, most recently from dcc82d7 to 31eee89 Compare May 14, 2018 15:56
@sjrd
Copy link
Member

sjrd commented May 14, 2018

Note that the partest lists are stuck on an older version of upstream 2.13.0-M4, so they are not actually run by this PR. This is because of scala/scala-dev#512.

They last correctly ran a few days ago. IMO it's not a blocker for a release of 0.6.23 that would support 2.13.0-M4.

@sjrd sjrd force-pushed the scala-2.13.0-M4-squashed branch from 31eee89 to 4948444 Compare May 14, 2018 18:45
@sjrd sjrd force-pushed the scala-2.13.0-M4-squashed branch 2 times, most recently from cc3cd1c to 71b813f Compare May 14, 2018 22:26
@SethTisue
Copy link
Contributor

is this superseded by #3361?

@sjrd
Copy link
Member

sjrd commented May 16, 2018

No, #3361 was only a relatively small part of this PR. It contained the minimum amount of changes that we needed to get a release out supporting M4. But there's still a lot to do, e.g., the tools API. The last commit of this PR is still relevant and will come later.

For most downstream projects, though, #3361 is enough (that was the point).

@sjrd sjrd force-pushed the scala-2.13.0-M4-squashed branch 2 times, most recently from d98817c to 2c839d4 Compare May 20, 2018 16:45
@sjrd sjrd force-pushed the scala-2.13.0-M4-squashed branch from 2c839d4 to 5eef2fb Compare May 20, 2018 16:54
@sjrd
Copy link
Member

sjrd commented May 20, 2018

Almost there. Now waiting for scala-parallel-collections to be built and published for 2.13.0-M4 ... scala/scala-parallel-collections#41

@julienrf
Copy link
Contributor Author

julienrf commented May 21, 2018 via email

@sjrd
Copy link
Member

sjrd commented May 21, 2018

That is unfortunate. Our linker is parallel because of the parallel collections.

A solution that does not involve scala-parallel-collections would require to rewrite the parallel parts of our linker not to use the parallel collections at all, which is probably also several weeks of work.

@julienrf
Copy link
Contributor Author

This will be fixed for 2.13.0 but in the meantime is it possible for you to disable the parallel linker?

@sjrd
Copy link
Member

sjrd commented May 21, 2018

Definitely not wholesale (on all Scala versions). Doing so would mean releasing sbt plugins that perform significantly worse than the current one.

We might be able to disable it when compiling for 2.13, but that would involve tricky manipulations of our source files, and we would have to revert them back when support for parallel collections catches up. That's not something I'm eager to undertake.

@sjrd
Copy link
Member

sjrd commented Jun 20, 2019

Superseded by #3702 and #3703.

@sjrd sjrd closed this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants