-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI ONLY Upgrade to Scala 2.13.0-M4 #3344
Conversation
ccdc040
to
d188957
Compare
d188957
to
0cca00f
Compare
0364ffd
to
b0068b5
Compare
I’ve updated the PR to use the latest Scala version to date (2.13.0-pre-91a7d72). I expect that after #3353 is merged the CI should run again but two tests are still expected to fail:
|
I merged #3353. If you still get a chance to rebase this PR on top of the latest 0.6.x before you go on vacation, it would probably make the PR close to being green again. Otherwise I'll eventually do it myself. |
b0068b5
to
d433e38
Compare
d433e38
to
e6a47c2
Compare
Rebased on top of #3359 and upgraded to the latest nightly of Scala. |
28232c2
to
2fa36d4
Compare
dcc82d7
to
31eee89
Compare
Note that the partest lists are stuck on an older version of upstream 2.13.0-M4, so they are not actually run by this PR. This is because of scala/scala-dev#512. They last correctly ran a few days ago. IMO it's not a blocker for a release of 0.6.23 that would support 2.13.0-M4. |
31eee89
to
4948444
Compare
cc3cd1c
to
71b813f
Compare
is this superseded by #3361? |
No, #3361 was only a relatively small part of this PR. It contained the minimum amount of changes that we needed to get a release out supporting M4. But there's still a lot to do, e.g., the tools API. The last commit of this PR is still relevant and will come later. For most downstream projects, though, #3361 is enough (that was the point). |
d98817c
to
2c839d4
Compare
2c839d4
to
5eef2fb
Compare
Almost there. Now waiting for scala-parallel-collections to be built and published for 2.13.0-M4 ... scala/scala-parallel-collections#41 |
Publishing the parallel collections is one month work that nobody has started yet, to my knowledge. I suggest to find a solution to not be blocked by the parallel collections.
…On May 20, 2018 10:58:05 PM GMT+02:00, "Sébastien Doeraene" ***@***.***> wrote:
Almost there. Now waiting for scala-parallel-collections to be built
and published for 2.13.0-M4 ...
scala/scala-parallel-collections#41
|
That is unfortunate. Our linker is parallel because of the parallel collections. A solution that does not involve scala-parallel-collections would require to rewrite the parallel parts of our linker not to use the parallel collections at all, which is probably also several weeks of work. |
This will be fixed for 2.13.0 but in the meantime is it possible for you to disable the parallel linker? |
Definitely not wholesale (on all Scala versions). Doing so would mean releasing sbt plugins that perform significantly worse than the current one. We might be able to disable it when compiling for 2.13, but that would involve tricky manipulations of our source files, and we would have to revert them back when support for parallel collections catches up. That's not something I'm eager to undertake. |
Continuation of #3344.