Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace --default-branch CLI with new syntax #292

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

alejandrohdezma
Copy link
Member

What has been done in this PR?

Add new default-repos-conf input. This input matches the --default-repos-conf from Scala Steward. It allows using a default .scala-steward.conf file by default for all repos updated with the action.

By default, it will tried to read it from .github/.scala-steward.conf.

Signed-off-by: Alejandro Hernández <[email protected]>
@github-actions github-actions bot added the enhancement New feature or request label Oct 19, 2021
Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alejandrohdezma alejandrohdezma merged commit 6c53713 into feature/default-branch Oct 19, 2021
@alejandrohdezma alejandrohdezma deleted the feature/default-repos-conf branch October 19, 2021 12:52
rtyley added a commit to guardian/scala-steward-public-repos that referenced this pull request Jul 15, 2022
Some third-party libraries widely used at the Guardian automatically
publish a new release every single day, often without obvious security
benefit. Currently we don't _automatically_ merge the resulting daily
Scala Steward PR, and so these low-value changes consume a lot of dev
attention. In general, we can accept a lower update cadence for these
dependencies. Some individual Guardian repos have already introduced
.scala-steward.conf config files to configure that cadence (see eg
guardian/ophan#4598 ), but to reduce
duplication of effort, it would be good to have this lower cadence
applied by default everywhere.

This update should configure our GitHub Action so that it will apply
the default lower-cadence config to _all_ repos it runs on, rather than
making devs individually configure it on every repo they work on,

The file location `.github/.scala-steward.conf` is the default value for
`repo-config` configuration input on the Scala Steward Github Action:

https://github.com/scala-steward-org/scala-steward-action#configuration

The feature of allowing the Scala Steward Github Action to have a default
for repo config was first introduced with
scala-steward-org/scala-steward-action#292,
the name of the configuration input was later switched from
`default-repo-conf` to `repo-config` with
scala-steward-org/scala-steward-action#324 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants