Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use File in Cli.Args #1653

Merged
merged 2 commits into from
Oct 11, 2020
Merged

Use File in Cli.Args #1653

merged 2 commits into from
Oct 11, 2020

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Oct 10, 2020

This uses File in Cli.Args so that we don't need Sync when converting
from Args to Config.

This uses `File` in `Cli.Args` so that we don't need `Sync` when converting
from `Args` to `Config`.
@fthomas fthomas added this to the 0.8.0 milestone Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #1653 into master will increase coverage by 0.08%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1653      +/-   ##
==========================================
+ Coverage   71.68%   71.76%   +0.08%     
==========================================
  Files         114      114              
  Lines        1875     1877       +2     
  Branches       57       55       -2     
==========================================
+ Hits         1344     1347       +3     
+ Misses        531      530       -1     
Impacted Files Coverage Δ
...ala/org/scalasteward/core/application/Config.scala 0.00% <0.00%> (ø)
...la/org/scalasteward/core/application/Context.scala 0.00% <0.00%> (ø)
.../scala/org/scalasteward/core/application/Cli.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b4d80...ec1153d. Read the comment docs.

@fthomas fthomas merged commit fd46985 into master Oct 11, 2020
@fthomas fthomas deleted the topic/use-File-in-Cli branch October 12, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant