Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KeyDecoder[Repo] instance #2291

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Remove KeyDecoder[Repo] instance #2291

merged 1 commit into from
Oct 16, 2021

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Oct 16, 2021

This is unused since #1220.

See #2281 (comment).

@alejandrohdezma I'm removing the instance here to keep the diff of #2281 focused on branch selection.

@fthomas fthomas added this to the 0.12.0 milestone Oct 16, 2021
@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #2291 (33135b9) into master (49fe121) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2291   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         135      135           
  Lines        2290     2286    -4     
  Branches       60       58    -2     
=======================================
- Hits         1783     1780    -3     
+ Misses        507      506    -1     
Impacted Files Coverage Δ
...in/scala/org/scalasteward/core/vcs/data/Repo.scala 100.00% <ø> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49fe121...33135b9. Read the comment docs.

@fthomas fthomas merged commit 13104a9 into master Oct 16, 2021
@fthomas fthomas deleted the topic/rm-repo-key-decoder branch October 16, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant