Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Repo.toPath #2292

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Add Repo.toPath #2292

merged 1 commit into from
Oct 16, 2021

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Oct 16, 2021

This adds Repo.toPath which has currently the same implementation as
Repo.show. show is used as representation in log messages while
toPath is used as path components.

This allows us in #2281 to use owner/repo:branch for show and
owner/repo/branch for toPath.

This adds `Repo.toPath` which has currently the same implementation as
`Repo.show`. `show` is used as representation in log messages while
`toPath` is used as path components.

This allows us in #2281 to use `owner/repo:branch` for `show` and
`owner/repo/branch` for `toPath`.
@fthomas fthomas added this to the 0.12.0 milestone Oct 16, 2021
@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #2292 (425b3f0) into master (13104a9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2292   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         135      135           
  Lines        2286     2286           
  Branches       58       59    +1     
=======================================
  Hits         1780     1780           
  Misses        506      506           
Impacted Files Coverage Δ
...main/scala/org/scalasteward/core/vcs/package.scala 100.00% <ø> (ø)
...in/scala/org/scalasteward/core/vcs/data/Repo.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13104a9...425b3f0. Read the comment docs.

@fthomas fthomas merged commit f6f1c7a into master Oct 16, 2021
@fthomas fthomas deleted the topic/repo-toPath branch October 16, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant