Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

declare versionScheme and enable MiMa #211

Merged
merged 3 commits into from
Mar 13, 2021
Merged

declare versionScheme and enable MiMa #211

merged 3 commits into from
Mar 13, 2021

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Mar 5, 2021 •
edited
Loading

fixes #210

@SethTisue
Copy link
Member Author

MiMa failures I'll need to dig into

@SethTisue SethTisue marked this pull request as draft March 5, 2021 19:05
@SethTisue SethTisue self-assigned this Mar 8, 2021
@SethTisue SethTisue mentioned this pull request Mar 9, 2021
Closed
@SethTisue
Copy link
Member Author

okay so the MiMa failures are only on 2.11 and 2.12, not on 2.13.

[error]  * method enrichAsJavaIntFunction(scala.Function1)scala.Function1 in trait scala.compat.java8.Priority1FunctionConverters does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.compat.java8.Priority1FunctionConverters.enrichAsJavaIntFunction")
[error]  * method enrichAsJavaIntFunction(scala.Function1,scala.Predef#=:=)scala.Function1 in trait scala.compat.java8.Priority1FunctionConverters is present only in current version
[error]    filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.compat.java8.Priority1FunctionConverters.enrichAsJavaIntFunction")
[error]  * method enrichAsJavaIntFunction(scala.Function1)scala.Function1 in object scala.compat.java8.FunctionConverters.package does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.compat.java8.FunctionConverters.package.enrichAsJavaIntFunction")
[error]  * static method enrichAsJavaIntFunction(scala.Function1)scala.Function1 in class scala.compat.java8.FunctionConverters.package does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.compat.java8.FunctionConverters.package.enrichAsJavaIntFunction")

@SethTisue SethTisue mentioned this pull request Mar 10, 2021
Closed
@SethTisue
Copy link
Member Author

I don't understand this. It seems to me we haven't touched this code.

I'm disinclined to spend my time digging into it. We're still in 0.x releases, and over at #213 we're planning on going 1.0, which means resetting binary compatibility anyway.

I'll just add an exclusion, and if it turns out this was a real problem we shouldn't have ignored, then I apologize to you, problem-experiencer-from-the-future.

@SethTisue SethTisue marked this pull request as ready for review March 13, 2021 19:54
@SethTisue SethTisue merged commit 05ca073 into scala:master Mar 13, 2021
@SethTisue SethTisue deleted the declare-version-scheme branch March 13, 2021 20:24
This was referenced Oct 3, 2021
Closed
Merged
@SethTisue SethTisue mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build should declare a versionScheme
1 participant
@SethTisue