add Scala 3 to crossbuild #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
this is already handled by sbt-scala-module
I do not fully understand why this was here, but Scala 3 was complaining: "Polymorphic refinement method valueStepper without matching type in parent trait MapOps is no longer allowed" simplifying the code as I have done in this commit compiles on both Scala versions and the tests still pass, and this is an obscure enough corner of the API that I'm not inclined to spend time really digging deeply into it (e.g. attempting to construct a test case that would now compile when it shouldn't, or vice versa)
|
This was routine work, with one exception, which I isolated in its own commit: 5160b41, which removes a type parameter which I couldn't figure out how to make Scala 3 accept ("Polymorphic refinement method valueStepper without matching type in parent trait MapOps is no longer allowed") ...but I also don't really understand under what circumstances it might matter and I'm not inclined to spend time really digging into it without some external indication that it's important @Ichoran Do you by any chance remember what that |
|
I'm going to go ahead and merge this so we can roll 1.0.0-RC1 for Scala 3.0.0-RC2. Still happy to receive feedback, post-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #200