Revert scala native support #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #130 (comment). |
SethTisue
approved these changes
Jan 31, 2018
|
@SethTisue the build succeeded, and the two staging repos on sonatype are |
|
@SethTisue can you Close and Release the two staging repos in sonatype? |
|
I'll push the tag to publish for 2.13.0-M3 in a few hours, not all maven central mirrors have picked up scala-js-0.6.22_2.13.0-M3 yet... |
|
yup, hopefully today, else tomorrow |
|
let's continue on #130 |
gourlaysama
added a commit
to gourlaysama/scala-parser-combinators
that referenced
this pull request
Oct 11, 2018
It was reverted in scala#135 because of build problems, but this is very easy to add now: we add a single 'jdk8 + scala 2.11.12' job to the build matrix, and also restrict publishing to those versions to be sure. Locally, the native subproject can be run with any jdk > 6 and works normally. fixes scala#141.
gourlaysama
added a commit
to gourlaysama/scala-parser-combinators
that referenced
this pull request
Oct 11, 2018
It was reverted in scala#135 because of build problems, but this is very easy to add now: we add a single 'jdk8 + scala 2.11.12' job to the build matrix, and also restrict publishing to those versions to be sure. Locally, the native subproject can be run with any jdk > 6 and works normally. fixes scala#141.
gourlaysama
added a commit
to gourlaysama/scala-parser-combinators
that referenced
this pull request
Oct 11, 2018
It was reverted in scala#135 because of build problems, but this is very easy to add now: we add a single 'jdk8 + scala 2.11.12' job to the build matrix, and also restrict publishing to those versions to be sure. Locally, the native subproject can be run with any jdk > 6 and works normally. fixes scala#141.
gourlaysama
added a commit
to gourlaysama/scala-parser-combinators
that referenced
this pull request
Oct 11, 2018
It was reverted in scala#135 because of build problems, but this is very easy to add now: we add a single 'jdk8 + scala 2.11.12' job to the build matrix, and also restrict publishing to those versions to be sure. Locally, the native subproject can be run with any jdk > 6 and works normally. fixes scala#141.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then we can release 1.0.7.