Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scala native to build matrix #204

Merged
merged 1 commit into from
Apr 14, 2019

Conversation

Philippus
Copy link
Member

@Philippus Philippus commented Apr 11, 2019

Applying this PR will add Scala native to the build matrix again, looks like it was removed by accident in #184.

@SethTisue
Copy link
Member

SethTisue commented Apr 11, 2019

I've never followed Scala Native stuff so I don't know if the build change is okay. I'm fine with the re-addition though. Perhaps it will need some extra attention the next time we publish. If we add this it might be a good idea to roll a release relatively soon afterwards in order to make sure the releasing part works.

@SethTisue
Copy link
Member

oh I see #201 now, great minds think alike :-)

@Philippus Philippus merged commit d3ebdf1 into scala:1.2.x Apr 14, 2019
@Philippus Philippus deleted the add-scala-native-to-build-matrix branch April 14, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants