-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and publish release v1.0.6 #97
Comments
@biswanaths Happy to review, but I can't see draft releases it seems. |
Here's the draft. Is it time to add @ashawley to the committers team, @biswanaths? :-) The following changes have been incorporated in this release
This release was made possible by contributions from @SethTisue,@adriaanm, @ashawley, @lrytz, @som-snytt. |
Those are some nice release notes! Looks like you're all set for v1.0.6! Once you publish the release, the commit will be tagged and travis will stage a release on sonatype. Let me know when it's done so I can push the button to promote the staging repo to maven central. |
Thanks for the mention, @adriaanm . I didn't have the gumption to adopt the module, but it's nice to see folks step up who can also exercise it! |
@biswanaths Release notes look good! All the items under "Administrative" are TBD -- they're not done yet. I only proposed those things. Sorry if that wasn't clear. Were you planning on doing them? |
@som-snytt, I'd love to take credit, but I didn't write the release notes, was just pasting them. @biswanaths wrote them |
Thanks @biswanaths ! What conscientiousness! Except for the part about not pasting the release notes. Just kidding! |
Any update on getting this released? |
I would like to address this #99 before pushing the release. Seems we are missing some paths for the OOM fix. Hopefully in couple of days. |
Oh yeah that seems like a good plan. Thanks for the update! |
I tried making this change in #98, but it didn't ended up going very smoothly for reasons I don't understand. It's not a blocker for the next release, though. |
Really looking forward to seeing #58 resolved! Is this going to be released soon? |
@biswanaths do you need help? perhaps some of the people commenting on this ticket could help you. |
@SethTisue , let me get through this. |
Really sorry for lot any and all for this inordinate delay. I am restarted to work on this. Please do expect a release in couple of days. |
Excellent! Thank you, @biswanaths! Looking forward to the release. |
@adriaanm , @SethTisue Can any of you help with |
tracking as scala/scala-dev#227. we'll get it in 2.12.1, assuming the 1.0.6 release goes well |
@adriaanm , https://github.com/scala/scala-xml/releases/tag/v1.0.6 Do I need to do anything else ? As mentioned previously can you help us pushing this to maven central ? |
@biswanaths Seems like #108 could be merged and added to 1.0.6. What do you think? |
@ashawley Sure enough. Already did a merge. I think have to look into creating new tag and release. |
over at https://oss.sonatype.org/content/repositories/orgscala-lang-1342/org/scala-lang/modules/ we see artifacts for 2.11, 2.12.0-M1, and 2.12.0-M5. since there are no 2.12.0-RC1 artifacts, since #108 was only merged later, instead of promoting that staging repository to Maven Central, I suggest we let it expire. you can delete the old v1.0.6 tag (keep a copy of the release notes!), merge #108, then push a new tag and Travis should publish again. once that's done, comment here and I'll take a look over on Sonatype to see if we got something we can promote this time. |
yes, scala/scala#5410 |
@biswanaths I took the liberty of revising the notes at https://github.com/scala/scala-xml/releases/tag/v1.0.6 a bit. in particular, I separated actual user-visible changes from other sorts of changes, and put the user-visible changes first. you might want to double-check that I classified the items correctly |
@SethTisue , release notes look much better. |
@SethTisue , deleting the tag and re-releasing with #108 as suggested by you looks better. We will do as such. |
Done, deleted the tag and released. @SethTisue let me know if you need anything else to push to sonatype. Also do we need to push it to maven central ? |
I closed and released the staging repos (there were two this time, I guess it must be timing-dependent whether you get one or two) at oss.sonatype.org just now (it's a manual step in the process that we do through the Sonatype web UI), so the artifacts should show up on Maven Central soon (within the next hour or so) |
1.0.6 is on Maven Central |
@ashawley can you double-check the release notes? |
The release notes look good to me. Those are indeed the user-visible changes that you listed first. Thanks! |
Should we tweet about this from http://twitter.com/scala_lang ? |
@SethTisue , would be great if we tweet. Hope it will drive towards some activity and help us. |
re: driving activity, scala_lang could retweet something you tweeted yourself, as well |
1.0.6 is bundled with Scala 2.12.1, which came out today |
Things to do before release
@SethTisue , @adriaanm , @ashawley Please do let me know, if I am missing anything for the release.
The text was updated successfully, but these errors were encountered: