Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and publish release v1.0.6 #97

Closed
biswanaths opened this issue Apr 22, 2016 · 40 comments
Closed

Create and publish release v1.0.6 #97

biswanaths opened this issue Apr 22, 2016 · 40 comments

Comments

@biswanaths
Copy link
Contributor

Things to do before release

@SethTisue , @adriaanm , @ashawley Please do let me know, if I am missing anything for the release.

@ashawley
Copy link
Member

@biswanaths Happy to review, but I can't see draft releases it seems.

@adriaanm
Copy link
Contributor

adriaanm commented Apr 22, 2016

Here's the draft. Is it time to add @ashawley to the committers team, @biswanaths? :-)

The following changes have been incorporated in this release

This release was made possible by contributions from @SethTisue,@adriaanm, @ashawley, @lrytz, @som-snytt.
We would like to thank them for their help.

@adriaanm
Copy link
Contributor

Those are some nice release notes! Looks like you're all set for v1.0.6! Once you publish the release, the commit will be tagged and travis will stage a release on sonatype. Let me know when it's done so I can push the button to promote the staging repo to maven central.

@som-snytt
Copy link
Contributor

Thanks for the mention, @adriaanm . I didn't have the gumption to adopt the module, but it's nice to see folks step up who can also exercise it!

@ashawley
Copy link
Member

@biswanaths Release notes look good!

All the items under "Administrative" are TBD -- they're not done yet. I only proposed those things. Sorry if that wasn't clear. Were you planning on doing them?

@adriaanm
Copy link
Contributor

@som-snytt, I'd love to take credit, but I didn't write the release notes, was just pasting them. @biswanaths wrote them

@som-snytt
Copy link
Contributor

Thanks @biswanaths ! What conscientiousness! Except for the part about not pasting the release notes. Just kidding!

@lespea
Copy link

lespea commented Apr 28, 2016

Any update on getting this released?

@biswanaths
Copy link
Contributor Author

I would like to address this #99 before pushing the release. Seems we are missing some paths for the OOM fix. Hopefully in couple of days.

@lespea
Copy link

lespea commented Apr 28, 2016

Oh yeah that seems like a good plan. Thanks for the update!

@ashawley
Copy link
Member

Change mimaPreviousVersion in build.sbt to more recent scala-xml than 1.0.1

I tried making this change in #98, but it didn't ended up going very smoothly for reasons I don't understand. It's not a blocker for the next release, though.

@ashawley
Copy link
Member

Ok, I resolved the issue with Mima by adding a commit to #98 that fixed it. I'd say we are good to release a new version of scala-xml once #98 and #100 are merged!

@ghost
Copy link

ghost commented Jul 5, 2016

Any ETA when this release due out in the wild? Keen to see #59 & #99 get out there. Looks like most things are ready to go. TIA

@sarahgerweck
Copy link

Like @devisaneer, I'd love to see this as well: the fix to #45 / #91 is something that would be quite useful for my project.

@EdgeCaseBerg
Copy link
Contributor

Really looking forward to seeing #58 resolved! Is this going to be released soon?

@SethTisue
Copy link
Member

@biswanaths do you need help? perhaps some of the people commenting on this ticket could help you.

@biswanaths
Copy link
Contributor Author

@SethTisue , let me get through this.

@biswanaths
Copy link
Contributor Author

Really sorry for lot any and all for this inordinate delay.

I am restarted to work on this. Please do expect a release in couple of days.

@biswanaths
Copy link
Contributor Author

biswanaths commented Sep 14, 2016

Merged #98 and #100 .

Thanks again @ashawley . Only if each of my thank was a dollar, Aaron would be a millionaire.

@ashawley
Copy link
Member

Excellent! Thank you, @biswanaths! Looking forward to the release.

@biswanaths
Copy link
Contributor Author

@adriaanm , @SethTisue Can any of you help with
" Ask Scala compiler to update versions.properties to next release of scala-xml" ?

@SethTisue
Copy link
Member

SethTisue commented Sep 15, 2016

Ask Scala compiler to update versions.properties to next release of scala-xml

tracking as scala/scala-dev#227. we'll get it in 2.12.1, assuming the 1.0.6 release goes well

@biswanaths
Copy link
Contributor Author

@adriaanm , https://github.com/scala/scala-xml/releases/tag/v1.0.6

Do I need to do anything else ? As mentioned previously can you help us pushing this to maven central ?

@ashawley
Copy link
Member

@biswanaths Seems like #108 could be merged and added to 1.0.6. What do you think?

@biswanaths
Copy link
Contributor Author

@ashawley Sure enough. Already did a merge. I think have to look into creating new tag and release.

@SethTisue
Copy link
Member

over at https://oss.sonatype.org/content/repositories/orgscala-lang-1342/org/scala-lang/modules/ we see artifacts for 2.11, 2.12.0-M1, and 2.12.0-M5. since there are no 2.12.0-RC1 artifacts, since #108 was only merged later, instead of promoting that staging repository to Maven Central, I suggest we let it expire. you can delete the old v1.0.6 tag (keep a copy of the release notes!), merge #108, then push a new tag and Travis should publish again. once that's done, comment here and I'll take a look over on Sonatype to see if we got something we can promote this time.

@SethTisue
Copy link
Member

@adriaanm , @SethTisue Can any of you help with
" Ask Scala compiler to update versions.properties to next release of scala-xml" ?

yes, scala/scala#5410

@SethTisue
Copy link
Member

SethTisue commented Sep 20, 2016

@biswanaths I took the liberty of revising the notes at https://github.com/scala/scala-xml/releases/tag/v1.0.6 a bit. in particular, I separated actual user-visible changes from other sorts of changes, and put the user-visible changes first. you might want to double-check that I classified the items correctly

@biswanaths
Copy link
Contributor Author

@SethTisue , release notes look much better.

@biswanaths
Copy link
Contributor Author

@SethTisue , deleting the tag and re-releasing with #108 as suggested by you looks better. We will do as such.

@biswanaths
Copy link
Contributor Author

Done, deleted the tag and released. @SethTisue let me know if you need anything else to push to sonatype. Also do we need to push it to maven central ?

@SethTisue
Copy link
Member

SethTisue commented Sep 20, 2016

I closed and released the staging repos (there were two this time, I guess it must be timing-dependent whether you get one or two) at oss.sonatype.org just now (it's a manual step in the process that we do through the Sonatype web UI), so the artifacts should show up on Maven Central soon (within the next hour or so)

@SethTisue
Copy link
Member

1.0.6 is on Maven Central

@SethTisue
Copy link
Member

All the items under "Administrative" are TBD -- they're not done yet. I only proposed those things. Sorry if that wasn't clear. Were you planning on doing them?

@ashawley can you double-check the release notes?

@ashawley
Copy link
Member

The release notes look good to me. Those are indeed the user-visible changes that you listed first. Thanks!

@SethTisue
Copy link
Member

Should we tweet about this from http://twitter.com/scala_lang ?

@biswanaths
Copy link
Contributor Author

@SethTisue , would be great if we tweet. Hope it will drive towards some activity and help us.

@SethTisue
Copy link
Member

@SethTisue
Copy link
Member

re: driving activity, scala_lang could retweet something you tweeted yourself, as well

@SethTisue
Copy link
Member

1.0.6 is bundled with Scala 2.12.1, which came out today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants