Fix #35 OOM on malformed input #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* src/test/scala/scala/xml/XMLTest.scala (issue35): New test. * src/test/scala/scala/xml/pull/XMLEventReaderTest.scala (issue35): New test.
* src/main/scala/scala/xml/parsing/MarkupParserCommon.scala (xAttributeValue): Check for eof in while loop.
|
Is there a timeline for releasing a version with this fix? |
|
Let me go through the the pull request. Also would be helpful ( also generally to any pull request) if people or two did some code review of the pull request. If everything looks fine, I will merge and do a release as quick as possible. |
|
I've built, run and read the code and can verify that the fix is correct. The unit tests look correct, too, but I haven't run them. |
|
I've been running it in prod for a month or so with no issues so far |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the fix from #44 by @som-snytt, but I've also added 2 unit tests to document the specific bug in #35.
I needed access to
scala.xml.Source, so I modified thepackagedeclarations in the tests.A unit test follows the convention of muting console output when the event reader is under test, see #82.