Commits on Feb 26, 2014

1. Revert "SI-7624 Fix -feature warnings in scala/tools/scalap" …

   This reverts commit f2de2c4 because it
   broke both lift-json and json4s libraries that depend on scalap's APIs.
   Arguably, those libraries shouldn't depend on unofficial APIs but they do
   because they had no better alternative at the time (no Scala reflection).
   
   The cost of breaking them is not worth minor change of the package.
   
   The f2de2c4 mixed two things:
   
     1. Fixing feature warnings
     2. Changing package name
   
   When reverting (and resolving conflicts) I tried to keep 1. and revert just
   2. However, there were also some questionable changes related to 1. that
   got reverted. In particular, a package object with implicit members that
   enable language features is an anti-pattern because members of package
   object are visible both _within_ and _outside_ of the package. Therefore,
   user could use wildcard import for importing everything from scalap
   package and enabled postfixOps language feature unknowingly. I went for
   just adding imports in just those few files where they were needed.
   
   Amended by Adriaan:
   To allow faster turn around, I re-enabled resolving partest from sonatype,
   as its version needs to be bumped and I don't want to wait for maven central synch.
   
   Conflicts:
   	src/partest/scala/tools/partest/nest/Runner.scala
   	src/scalap/scala/tools/scalap/scalax/rules/Memoisable.scala
   	src/scalap/scala/tools/scalap/scalax/rules/Rule.scala
   	src/scalap/scala/tools/scalap/scalax/rules/Rules.scala
   	src/scalap/scala/tools/scalap/scalax/rules/scalasig/ClassFileParser.scala
   	src/scalap/scala/tools/scalap/scalax/rules/scalasig/ScalaSig.scala

   

   gkossakowski authored and adriaanm committed Feb 26, 2014
   Configuration menu

   • View commit details
   • Copy full SHA for 7bb1f41
   • Browse repository at this point

   Copy the full SHA

   7bb1f41 View commit details

   Browse the repository at this point in the history