Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove () from iterator #6620

Merged
merged 4 commits into from
May 14, 2018
Merged

Remove () from iterator #6620

merged 4 commits into from
May 14, 2018

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented May 11, 2018

@julienrf
Copy link
Contributor

If this gets merged we should:

@lrytz lrytz requested review from szeiger and julienrf May 11, 2018 09:07
@lrytz lrytz modified the milestones: 2.13.0-M5, 2.13.0-M4 May 13, 2018
@julienrf
Copy link
Contributor

As mentioned here scala/collection-strawman#520 (comment), we should also remove the parens to the XxxFactory#newBuilder operation. And probably to IterableOps#newSpecificBuilder as well (though this one didn’t exist in 2.12, so it’s not a problem to keep the parens, but we should just use the same convention everywhere…)

@lrytz
Copy link
Member Author

lrytz commented May 13, 2018

I just did that, just need to push the changes

@sjrd
Copy link
Member

sjrd commented May 13, 2018

Because of the change in newBuilder especially, we'll need this PR to land (and a -pre- to be built from it) before we can finalize changes in Scala.js, so the sooner it gets merged, the likelier it gets that Scala.js can be ready (almost) in time for the release.

@sjrd
Copy link
Member

sjrd commented May 13, 2018

@lrytz Hum for newBuilder, don't you also want to remove the () in IterableFactory.newBuilder[A]() and all its implementations?

Also MapFactory.newBuilder[K, V]().

@julienrf
Copy link
Contributor

Good catch @sjrd. Indeed we should remove the () here too.

@lrytz lrytz force-pushed the strawman520 branch 2 times, most recently from 1b5100b to c48233d Compare May 13, 2018 21:21
@lrytz lrytz force-pushed the strawman520 branch 2 times, most recently from 1edab58 to 8b8cf68 Compare May 13, 2018 21:40
@lrytz
Copy link
Member Author

lrytz commented May 13, 2018

I think I caught them all now. Also added a commit for ArrayBuilder.make.

@lrytz
Copy link
Member Author

lrytz commented May 14, 2018

ArrayBuilder.make actually had () in 2.12, so this is a breaking change. https://github.com/scala/scala/blob/v2.12.6/src/library/scala/collection/mutable/ArrayBuilder.scala#L34

Copy link
Contributor

@szeiger szeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of adding another breaking change but it makes it consistent with the rest.

@lrytz lrytz merged commit e2094bf into scala:2.13.x May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants