Wunused: Check if symbol exists before isValidMemberDef check

closes lampepfl#17309
scala · Apr 26, 2023 · 716b867 · 716b867
1 parent 40502e0
commit 716b867
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/compiler/src/dotty/tools/dotc/transform/CheckUnused.scala b/compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
@@ -681,7 +681,7 @@ object CheckUnused:
       /** A function is overriden. Either has `override flags` or parent has a matching member (type and name) */
       private def isOverriden(using Context): Boolean =
         sym.is(Flags.Override) ||
-        (if sym.exists then sym.owner.thisType.parents.exists(p => sym.matchingMember(p).exists) else false)
+          (sym.exists && sym.owner.thisType.parents.exists(p => sym.matchingMember(p).exists))
 
     end extension
 
@@ -708,7 +708,11 @@ object CheckUnused:
 
     extension (memDef: tpd.MemberDef)
       private def isValidMemberDef(using Context): Boolean =
-        !memDef.symbol.isUnusedAnnot && !memDef.symbol.isAllOf(Flags.AccessorCreationFlags) && !memDef.name.isWildcard && !memDef.symbol.owner.is(Extension)
+        memDef.symbol.exists
+          && !memDef.symbol.isUnusedAnnot
+          && !memDef.symbol.isAllOf(Flags.AccessorCreationFlags)
+          && !memDef.name.isWildcard
+          && !memDef.symbol.owner.is(ExtensionMethod)
 
       private def isValidParam(using Context): Boolean =
         val sym = memDef.symbol