Skip to content

Commit

Permalink
Keep qualifier of Ident when selecting setter
Browse files Browse the repository at this point in the history
We already keep the qualifier as a typed splice if the prefix is an
explicit Select.

Fixes #18713
  • Loading branch information
nicolasstucki committed Nov 9, 2023
1 parent 44a537b commit b682f68
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
13 changes: 12 additions & 1 deletion compiler/src/dotty/tools/dotc/typer/Typer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,18 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer
case Apply(fn, _) if fn.symbol.is(ExtensionMethod) =>
def toSetter(fn: Tree): untpd.Tree = fn match
case fn @ Ident(name: TermName) =>
untpd.cpy.Ident(fn)(name.setterName)
// We need to make sure that the prefix of this extension getter is
// retained when we transform it into a setter. Otherwise, we could
// end up resoving an unrelated setter from another extension. We
// transform the `Ident` into a `Select` to ensure that the prefix
// is retained with a `TypedSplice` (see `case Select` bellow).
fn.tpe match
case TermRef(qual: TermRef, _) =>
toSetter(ref(qual).select(fn.symbol).withSpan(fn.span))
case TermRef(qual: ThisType, _) =>
toSetter(This(qual.cls).select(fn.symbol).withSpan(fn.span))
case TermRef(NoPrefix, _) =>
untpd.cpy.Ident(fn)(name.setterName)
case fn @ Select(qual, name: TermName) =>
untpd.cpy.Select(fn)(untpd.TypedSplice(qual), name.setterName)
case fn @ TypeApply(fn1, targs) =>
Expand Down
18 changes: 18 additions & 0 deletions tests/pos/i18713.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import language.experimental.relaxedExtensionImports

class A
object AA:
extension (a: A)
def f = ???
def f_=(x: String) = ???

object BB:
extension (b: Long)
def f = ???
def f_=(x: String) = ???

def test(a: A) =
import AA.*
import BB.*
a.f
a.f = "aa"

0 comments on commit b682f68

Please sign in to comment.