Recognize named arguments in isFunctionWithUnknownParamType (#17161)

fixes #17155
scala · Mar 28, 2023 · d640193 · d640193
2 parents 3a830c8 + 1d497f5
commit d640193
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/compiler/src/dotty/tools/dotc/ast/TreeInfo.scala b/compiler/src/dotty/tools/dotc/ast/TreeInfo.scala
@@ -399,6 +399,8 @@ trait UntypedTreeInfo extends TreeInfo[Untyped] { self: Trees.Instance[Untyped]
       Some(tree)
     case Block(Nil, expr) =>
       functionWithUnknownParamType(expr)
+    case NamedArg(_, expr) =>
+      functionWithUnknownParamType(expr)
     case _ =>
       None
   }

diff --git a/compiler/src/dotty/tools/dotc/typer/Applications.scala b/compiler/src/dotty/tools/dotc/typer/Applications.scala
@@ -448,7 +448,7 @@ trait Applications extends Compatibility {
       def rec(t: Type): Type = {
         t.widen match{
           case funType: MethodType => funType
-          case funType: PolyType => 
+          case funType: PolyType =>
             rec(instantiateWithTypeVars(funType))
           case tp => tp
         }

diff --git a/tests/pos/i17155.scala b/tests/pos/i17155.scala
@@ -0,0 +1,7 @@
+def foo[A, B](arr: Array[A], pf: PartialFunction[A, B]): Seq[B] = arr.toSeq.collect(pf)
+def foo[A, B](list: List[A], pf: PartialFunction[A, B]): Seq[B] = list.collect(pf) // no errors if this is commented out
+
+val arr = Array(1, 2, 3)
+val resOkay = foo(arr = arr, { case n if n % 2 != 0 => n.toString }) // compiles
+val resNope = foo(arr = arr, pf = { case n if n % 2 != 0 => n.toString }) // Error 1
+val resNope2 = foo[Int, String](arr = arr, pf = { case n if n % 2 != 0 => n.toString }) // Error 2