Fix #9424: Add releaseFence() call when mixing in a trait val.
#10493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Nov 25, 2020
There was a problem hiding this comment.
Any idea how to test this?
I would be happy with a bytecode test (see https://github.com/lampepfl/dotty/blob/master/compiler/test/dotty/tools/backend/jvm/DottyBytecodeTests.scala) that verifies that the call is added in a few situations (and not added when not needed). Ideally we should port the jcstress test too, but even in scala 2 it's not hooked up to the CI...
This is a forward port of relevant parts of the upstream PR scala/scala#7028
|
Bytecode tests added :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward port of relevant parts of the upstream PR
scala/scala#7028
Any idea how to test this? scala/scala used a jstress test for that, but it's outside my area of expertise at the moment. I "tested" it by inspection in a variety of cases (when it must appear and it must not appear), but that doesn't give much confidence.