Warn when ??? is used to implement erased definition #11740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 15, 2021
nicolasstucki
force-pushed
the
fix-#11739
branch
from
69b8d23
to
4d8749d
Compare
nicolasstucki
commented
Mar 15, 2021
| @@ -69,6 +73,12 @@ class PruneErasedDefs extends MiniPhase with SymTransformer { thisTransform => | |||
| else tree | |||
|
|
|||
| private def trivialErasedTree(tree: Tree)(using Context): Tree = | |||
| tree match | |||
| case tree: ValOrDefDef if !tree.symbol.is(Inline) && !tree.symbol.is(Synthetic) => | |||
| if tree.rhs.symbol == defn.Predef_undefined then | |||
There was a problem hiding this comment.
Next step might be to do tree.rhs.symbol != defn.Compiletime_erasedValue.
liufengyun
reviewed
Mar 15, 2021
There was a problem hiding this comment.
In #11721 , it uses ??? for erased definitions. Is there a potential conflict?
|
It is possible. Currently, it seems not non of the tests have fatal warning. It should be fine. |
In #11721 , it uses |
|
That is not on the RHS of an erased definition. It will be fine. |
Could you elaborate? In |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.