Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize match type usage during implicit lookup #17457

Merged
merged 1 commit into from
May 12, 2023

Conversation

dwijnand
Copy link
Member

No description provided.

@dwijnand dwijnand requested a review from odersky May 10, 2023 20:46
@dwijnand dwijnand marked this pull request as ready for review May 10, 2023 20:46
@dwijnand
Copy link
Member Author

@odersky You mentioned this may cause problems, so @Decel and I had a go, and found this reasonable looking patch that doesn't seem to break our test suite or any of the community build projects. What do you make of it?

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit fa9fda8 into scala:main May 12, 2023
@dwijnand dwijnand deleted the match-type-implicit-scopes branch May 13, 2023 17:58
@soronpo
Copy link
Contributor

soronpo commented Jul 8, 2023

This PR causes a stack overflow regression #18171 due to recursive invocation of traverseChildren

@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 1, 2023
Kordyjan added a commit that referenced this pull request Aug 22, 2023
…18440)

Reverts #17457.
This fix caused significant challenges in maintaining the source
compatibility. We decided not to include it in 3.3.1. It will still be a
part of 3.4 and future Scala Next versions.

It is possible that in the future, an improved version of this fix will
make it to one of 3.3.x releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit not found for the result of match type, although it's declared in the companion object
4 participants