Backport "Fix regression in exhausitivity of HK types" #18374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivating case (i16451) is complicated, because it involves unchecked type arguments. To fix the regression, I'm reverting the fix.
| @@ -678,8 +669,8 @@ object SpaceEngine { | |||
| rec(tp, Nil) | |||
| } | |||
|
|
|||
| extension (cls: Symbol) | |||
| /** A type is decomposable to children if it's sealed, | |||
| extension (tp: Type) | |||
There was a problem hiding this comment.
This change changes binary compatibility of our public, yet private API.
However, I don't think anyone would try to access any of this extension method
There was a problem hiding this comment.
We have enough problems and difficulties. Let's not find ways to add new ones. None of this is supported public API, and is subject to any change.
WojciechMazur
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #18303