Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec] Cosmetic changes in the lexical syntax chapter #18608

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Sep 28, 2023

The highlighter does not print all keywords with the same color,
which makes sense in actual code snippets, but is confusing in the
raw lists of all keywords.
>: # [ ) ] }
```
catch else extends finally forSome match with yield
, . ; : = => <- <: <% >: # [ ) ] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, . ; : = => <- <: <% >: # [ ) ] }
, . ; : = => <- <: <% >: # ) ] }

looks like this can go due to polymorphic lambdas now being added

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point. That's a normative change, though, so I'll do that in a separate PR.

@bishabosha bishabosha merged commit acee11f into scala:main Sep 28, 2023
18 checks passed
@bishabosha bishabosha deleted the spec-lexical-cosmetics branch September 28, 2023 13:09
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
…TS (#20625)

Backports #18608 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
…TS (#20682)

Backports #18608 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants