Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Completions for named args in wrong order #18702

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

jkciesluk
Copy link
Contributor

connected to scalameta/metals#5728

* )
* In this case, typed path doesn't contain already provided arguments
*/
NavigateAST.untypedPath(pos.span) match
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untyped path is already computed for the completions. We shouldn't recompute it. Check for
val adjustedPath = Completion.resolveTypedOrUntypedPath(path, pos)

@rochala rochala merged commit b9cd807 into scala:main Nov 10, 2023
18 checks passed
@jkciesluk jkciesluk deleted the named-wrong-order branch November 10, 2023 14:07
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
WojciechMazur pushed a commit that referenced this pull request Jun 27, 2024
WojciechMazur added a commit that referenced this pull request Jun 28, 2024
…20822)

Backports #18702 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants