Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add explanation twice #18779

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Don't add explanation twice #18779

merged 2 commits into from
Nov 15, 2023

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Oct 28, 2023 •
edited
Loading

Fixes #18774

The improvement was #14357

@som-snytt
Copy link
Contributor Author

I expected a test failure.

@som-snytt som-snytt marked this pull request as ready for review October 30, 2023 17:51
@dwijnand
Copy link
Member

Some of your puns are too hard for me to parse, but I've come so used to seeing them I was surprised you didn't go for something along the lines of: explain to me once, shame on me, explain to me twice, shame on you... :-P

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Nov 6, 2023 •
edited
Loading

I am wondering if we can test this in sbt-test/. It seems that sbt-test/compilerReporter/i14576/build.sbt does has the base logic we need.

@nicolasstucki
Copy link
Contributor

I am wondering if we can test this in sbt-test/. It seems that sbt-test/compilerReporter/i14576/build.sbt does has the base logic we need.

I tried it and that does not work as the extra -explain does not go through the test reporter. I guess it is good enough like this.

@nicolasstucki nicolasstucki merged commit b573b5f into scala:main Nov 15, 2023
18 checks passed
@som-snytt som-snytt deleted the test/message branch November 15, 2023 15:15
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 23, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 23, 2024
@WojciechMazur
Backport "Don't add explanation twice" to LTS (#20749)
d44cbd7 
Backports #18779 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Every explanation is printed twice with -explain and sbt
4 participants
@som-snytt @dwijnand @nicolasstucki @Kordyjan