Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider all parents when checking access to the children of a sum #19083

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Consider all parents when checking access to the children of a sum #19083

merged 2 commits into from
Nov 27, 2023

Conversation

EugeneFlesselle
Copy link
Contributor

@EugeneFlesselle EugeneFlesselle commented Nov 26, 2023 •
edited
Loading

Fix #18918

@EugeneFlesselle EugeneFlesselle changed the title [WIP] Consider all parents when checking access to the children of a sum Consider all parents when checking access to the children of a sum Nov 27, 2023
@EugeneFlesselle EugeneFlesselle marked this pull request as ready for review November 27, 2023 13:35
bishabosha
bishabosha approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@EugeneFlesselle @bishabosha
Use classSymbols method
5b2ec61 
Co-authored-by: Jamie Thompson <[email protected]>
@bishabosha bishabosha merged commit 5fb2299 into scala:main Nov 27, 2023
16 checks passed
@EugeneFlesselle EugeneFlesselle deleted the i18918 branch November 27, 2023 21:34
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 23, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 23, 2024
@WojciechMazur
Backport "Consider all parents when checking access to the children o…
53eeabf 
…f a sum" to LTS (#20767)

Backports #19083 to the LTS branch.

PR submitted by the release tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Failed to derive mirror in trait with self type
3 participants
@EugeneFlesselle @bishabosha @Kordyjan