Update staging.Compiler.make documentation
#19428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses part of scala#19211, scala#19170, and scala#19176
|
@christophkoch This update of documentation should unblock your use cases. |
nicolasstucki
force-pushed
the
fix-19211
branch
from
78f9328
to
24e8884
Compare
jchyb
requested changes
Jan 12, 2024
| case ex: java.lang.NoClassDefFoundError => | ||
| throw new Exception( | ||
| s"""`scala.quoted.staging.run` failed to load a class. | ||
| |The classloader used for the `staging.Compiler` instance might be the correct one. |
There was a problem hiding this comment.
Suggested change
| |The classloader used for the `staging.Compiler` instance might be the correct one. | |
| |The classloader used for the `staging.Compiler` instance might not be the correct one. |
There was a problem hiding this comment.
I think you have lost the not here, everything else looks good to me
nicolasstucki
force-pushed
the
fix-19211
branch
from
24e8884
to
a34cd7d
Compare
jchyb
approved these changes
Jan 15, 2024
WojciechMazur
added a commit
that referenced
this pull request
Jun 28, 2024
Backports #19428 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19211
This addresses part of #19170, and #19176