Scala 2.13.12 (was 2.13.10) #19454
Merged
Scala 2.13.12 (was 2.13.10) #19454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
force-pushed
the
scala-2.13.12-for-3.3.2
branch
from
aca92f4
to
1e18d84
Compare
SethTisue
force-pushed
the
scala-2.13.12-for-3.3.2
branch
from
1e18d84
to
43381ee
Compare
SethTisue
force-pushed
the
scala-2.13.12-for-3.3.2
branch
from
43381ee
to
d20dbbc
Compare
Kordyjan
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Apart from a single comment, everything looks good. We can have it in 3.3.2.
It also reminds me that we will probably be unable to bump Scala 2 standard library versions in the LTS once scala/improvement-proposals#54 is in effect. This needs some discussion.
Comment on lines
-855
to
857
| |higherKinds scala.languageFeature | ||
| |implicitConversions scala.languageFeature | ||
| |postfixOps scala.languageFeature | ||
| |""".stripMargin, |
There was a problem hiding this comment.
Do we know why did it change?
There was a problem hiding this comment.
Might be related to #19468
Is this for technical reasons or not? |
|
will merge-conflict in one place with #19492, easily resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #18525 , which was on the "Scala 3.3 LTS backports" project board but seems to have been overlooked
@Kordyjan is it too late for this to make 3.3.2...?
fyi @lrytz
yes, I think we should ship this even though 2.13.13 is coming soon