-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#19806): wrong tasty of scala module class reference #19827
Merged
bishabosha
merged 8 commits into
scala:main
from
i10416:fix/19806-wrong-tasty-of-scala-mod-cls-ref
Mar 13, 2024
Merged
fix(#19806): wrong tasty of scala module class reference #19827
bishabosha
merged 8 commits into
scala:main
from
i10416:fix/19806-wrong-tasty-of-scala-mod-cls-ref
Mar 13, 2024
Commits on Feb 29, 2024
-
fix(scala#19806): wrong tasty of scala module class reference
This commit makes the following diff to TASTy for i17255 files. The TASTy before this commit relied on the compiler (aka all TASTy clients) intrinsically knowing how to resolve Module$ when the definition is actually Module[ModuleClass]. ```sh scalac tests/run/i17255/J.java tests/run/i17255/Module.scala -Yprint-tasty -Yjava-tasty ``` ```diff 90: EMPTYCLAUSE 91: TERMREF 17 [Module] 93: SHAREDtype 12 95: ELIDED 96: SHAREDtype 91 98: STATIC 99: DEFDEF(12) 18 [module] 102: EMPTYCLAUSE - 103: SELECTtpt 19 [Module$] + 103: SELECTtpt 19 [Module[ModuleClass]] 105: SHAREDtype 3 107: ELIDED 108: TYPEREF 17 [Module] 110: SHAREDtype 3 112: STATIC ```
Configuration menu - View commit details
-
Copy full SHA for 2708c8c - Browse repository at this point
Copy the full SHA 2708c8cView commit details
Commits on Mar 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a4a379f - Browse repository at this point
Copy the full SHA a4a379fView commit details
Commits on Mar 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 373e8e9 - Browse repository at this point
Copy the full SHA 373e8e9View commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8920162 - Browse repository at this point
Copy the full SHA 8920162View commit details -
Configuration menu - View commit details
-
Copy full SHA for 090b647 - Browse repository at this point
Copy the full SHA 090b647View commit details -
Configuration menu - View commit details
-
Copy full SHA for 923f63f - Browse repository at this point
Copy the full SHA 923f63fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e1bba5 - Browse repository at this point
Copy the full SHA 6e1bba5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d5db00 - Browse repository at this point
Copy the full SHA 1d5db00View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.