Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#19806): wrong tasty of scala module class reference #19827

Merged

Commits on Feb 29, 2024

  1. fix(scala#19806): wrong tasty of scala module class reference

    This commit makes the following diff to TASTy for i17255
    files. The TASTy before this commit relied on the compiler (aka all TASTy clients)
    intrinsically knowing how to resolve Module$ when the definition is actually Module[ModuleClass].
    
    ```sh
    scalac tests/run/i17255/J.java tests/run/i17255/Module.scala -Yprint-tasty -Yjava-tasty
    ```
    
    ```diff
        90:         EMPTYCLAUSE
        91:         TERMREF 17 [Module]
        93:           SHAREDtype 12
        95:         ELIDED
        96:           SHAREDtype 91
        98:         STATIC
        99:       DEFDEF(12) 18 [module]
       102:         EMPTYCLAUSE
    -  103:         SELECTtpt 19 [Module$]
    +  103:         SELECTtpt 19 [Module[ModuleClass]]
       105:           SHAREDtype 3
       107:         ELIDED
       108:           TYPEREF 17 [Module]
       110:             SHAREDtype 3
       112:         STATIC
    ```
    i10416 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2708c8c View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    a4a379f View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    373e8e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Configuration menu
    Copy the full SHA
    8920162 View commit details
    Browse the repository at this point in the history
  2. elide source file names

    bishabosha committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    090b647 View commit details
    Browse the repository at this point in the history
  3. check lines not whole file

    bishabosha committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    923f63f View commit details
    Browse the repository at this point in the history
  4. print what is the diff

    bishabosha committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6e1bba5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1d5db00 View commit details
    Browse the repository at this point in the history