Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TermRef prefixes not having their type healed #20102

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jchyb
Copy link
Contributor

@jchyb jchyb commented Apr 5, 2024

Fixes #19767

In the minimization from the issue, after the splicing phase we ended up with a quote with illegal k1 types, which should have been healed during the splicing phase:

'<k1$given2>{
  new ICons[(ICons[k1]#key : k1)](
  //...

To fix that, we now map over and heal the prefix of the TermRef as well, so we end up with:

'<k1$given2>{
  new ICons[(ICons[k1$given2]#key : k1$given2)](
  //...

@nicolasstucki nicolasstucki merged commit 617f309 into scala:main Apr 5, 2024
19 checks passed
@nicolasstucki nicolasstucki deleted the fix-i19767 branch April 5, 2024 15:36
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
WojciechMazur added a commit that referenced this pull request Jul 5, 2024
…21038)

Backports #20102 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible regression to 3.3.1: unhandled exception while running pickleQuotes
3 participants