Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update asm to patched 9.7 #20144

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Update asm to patched 9.7 #20144

merged 1 commit into from
Aug 26, 2024

Conversation

Philippus
Copy link
Member

No description provided.

@Philippus
Copy link
Member Author

Note that on Scala 2.13, this update fails the build: scala/scala#10744.

@SethTisue SethTisue marked this pull request as draft April 9, 2024 22:28
@SethTisue
Copy link
Member

marking as draft for now until we figure out what's going on over in Scala 2

@Philippus Philippus changed the title Update asm to 9.7 Update asm to patched 9.7 Aug 11, 2024
@Philippus
Copy link
Member Author

Updated to the patched asm 9.7 (like in scala/scala#10744), not sure if other changes are needed.

@SethTisue SethTisue self-assigned this Aug 13, 2024
@SethTisue SethTisue marked this pull request as ready for review August 14, 2024 03:11
@SethTisue SethTisue removed their assignment Aug 14, 2024
@SethTisue SethTisue added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Aug 14, 2024
@SethTisue
Copy link
Member

SethTisue commented Aug 14, 2024 •
edited
Loading

not sure if other changes are needed

it doesn't seem so. test suite passes. the change Lukas made in the Scala 2 PR only affects the optimizer which doesn't exist in Scala 3

@SethTisue
Copy link
Member

@hamzaremmal I don't know on what timetable JDK 23 should be added to the CI matrix here. We are in the process of adding it to the Scala 2 CI matrix, including the Scala 2 community build.

@timothyklim
Copy link

Is there any estimates when it'll be merged and went to nightly? Thanks

@SethTisue SethTisue merged commit dd37503 into scala:main Aug 26, 2024
28 checks passed
@Philippus Philippus deleted the update/asm-9.7 branch August 26, 2024 14:52
@WojciechMazur
Copy link
Contributor

Is there any estimates when it'll be merged and went to nightly? Thanks

It should already be available in 3.6.0-RC1-bin-20240826-c0cfd0f-NIGHTLY - the commit SHA used for that nightly is a successor of this PR

@WojciechMazur WojciechMazur mentioned this pull request Aug 28, 2024
Merged
WojciechMazur added a commit that referenced this pull request Aug 28, 2024
@WojciechMazur
Backport "Update asm to patched 9.7" to 3.5.2 (#21499)
41591ae 
Backports #20144 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added this to the 3.5.2 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees
No one assigned
Labels
backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it.
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Philippus @SethTisue @timothyklim @WojciechMazur