Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crash when superType does not exist after erasure #20188

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Avoid crash when superType does not exist after erasure #20188

merged 3 commits into from
Apr 15, 2024

Commits on Apr 15, 2024

  1. Avoid crash when superType does not exist after erasure 

    Fixes scala#19929

Two main changes:

 - In TypeErasure, throw a TypeError instead of a FatalError if a supertype of an applied
   type does not exist. That way, we get a proper error with a position.
 - Move some catch-and-rethrow logic from ReTyper to TreeChecker. ReTyper alreayd had special
   exceptions that disabled the logic for all uses of ReTyper except TreeChecker. Unfortunately
   the ReTyper override also disabled the special TypeError handling in Typer.
    @odersky
    odersky committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    822e792 View commit details
    Browse the repository at this point in the history

  2. Reclassify test

    @odersky
    odersky committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    4920146 View commit details
    Browse the repository at this point in the history

  3. Amend reclassify test

    @EugeneFlesselle
    EugeneFlesselle committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    16d9e3d View commit details
    Browse the repository at this point in the history