#20145 - bugfix when a return tail rec is called inside a val #20632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l definition, previously this would neither optimise nor fail.
LucySMartin
force-pushed
the
tail-rec-value-def
branch
from
e80fb07
to
c50d0a3
Compare
…l definition, previously this would neither optimise nor fail.
|
I know I had this working at one point. Feel free to ignore this for now, ill be more careful fixing it up... |
som-snytt
reviewed
Jun 19, 2024
| } | ||
| } | ||
| @main def Test = | ||
| println(foo(0)) |
There was a problem hiding this comment.
Unrelatedly, you can assert(foo(0) == K) to avoid introducing a check file.
Also, a PR can be in "draft" mode to mean "not ready for review". If you accidentally push to your branch while a PR is closed, it doesn't let you re-open the PR (for some reason).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20145
Prior to this fix, this test case threw a stack overflow of self calls, despite the @tailrec annotation.
Was simpler to have it work than have it error out.