Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default source version to 3.6 #20895

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

hamzaremmal
Copy link
Member

No description provided.

@hamzaremmal hamzaremmal self-assigned this Jun 29, 2024
@hamzaremmal hamzaremmal added the needs-minor-release This PR cannot be merged until the next minor release label Jun 29, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this is the correct error to show. It should keep the following message:

-- [E007] Type Mismatch Error: tests/neg/i7294.scala:7:18 --------------------------------------------------------------
7 |  case x: T => x.g(10) // error // error
  |               ^^^^^^^
  |               Found:    Any
  |               Required: T
  |
  |               where:    T is a type in given instance f with bounds <: foo.Foo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related issue: #20992

@hamzaremmal hamzaremmal marked this pull request as ready for review July 3, 2024 14:28
@hamzaremmal hamzaremmal removed their assignment Jul 3, 2024
@bishabosha
Copy link
Member

you can't add a 3.7 mode before 3.7?

@hamzaremmal
Copy link
Member Author

you can't add a 3.7 mode before 3.7?

No, I checked with @odersky this afternoon and this is the way it is supposed to be done

@bishabosha
Copy link
Member

No, I checked with @odersky this afternoon and this is the way it is supposed to be done

it seems since 3.4 this was the case (it had 3.5 source versions), but until then this never happened, so I did find it strange

@WojciechMazur WojciechMazur merged commit e7fa3f6 into scala:main Jul 4, 2024
24 checks passed
@hamzaremmal hamzaremmal deleted the switch-source-3.6 branch July 4, 2024 08:00
@Gedochao
Copy link
Contributor

Gedochao commented Jul 4, 2024

This has been decided to be included in the 3.6.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-minor-release This PR cannot be merged until the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants