Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CompletionScalaCliSuite tests due to circe releasing Scala Native 0.5 artifacts #20931

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

WojciechMazur
Copy link
Contributor

The recent release of circe for SN 0.5 changed the outputs of CompletionScalaCli suite. The PR fixes failing tests

Copy link
Contributor

@rochala rochala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find a better way to handle this kind of completions.

@tgodzik Coursier is quite big dependency and we only use it for this purpose. Maybe we could change the interface in a way that allows us to provide a handler for this kind of completions, and move away logic form the presentation compiler ?

@WojciechMazur
Copy link
Contributor Author

We should find a better way to handle this kind of completions.

Agree. It's just a fast fix although it seems that presentation compiler is not tested in the CI (I think so), but it started to fail locally. In such case if it's not blocking CI we can take time to make a better solution

@WojciechMazur WojciechMazur marked this pull request as draft July 1, 2024 22:47
@WojciechMazur
Copy link
Contributor Author

Surprisingly the CI failed in all of the modified tests. We would need to check why it behaves differently locally and in the CI

@tgodzik
Copy link
Contributor

tgodzik commented Jul 2, 2024

Surprisingly the CI failed in all of the modified tests. We would need to check why it behaves differently locally and in the CI

That is highly surprising, this is basically cs complete-dep and its' output seems to work

We should find a better way to handle this kind of completions.

@tgodzik Coursier is quite big dependency and we only use it for this purpose. Maybe we could change the interface in a way that allows us to provide a handler for this kind of completions, and move away logic form the presentation compiler ?

We could add that to SymbolSearch interface, it would probably make sense and just mock it, test it inside metals

@tgodzik
Copy link
Contributor

tgodzik commented Jul 2, 2024

If needed you can ignore the tests for now.

@hamzaremmal hamzaremmal linked an issue Jul 2, 2024 that may be closed by this pull request
…4 and 0.5 SN versins - the outputs seems be non deterministic in the CI
@WojciechMazur WojciechMazur marked this pull request as ready for review July 2, 2024 10:35
@hamzaremmal
Copy link
Member

Blocking #20837

@hamzaremmal hamzaremmal merged commit 3f57b29 into scala:main Jul 2, 2024
20 checks passed
@WojciechMazur WojciechMazur deleted the fix/completionScalaCliSuite branch July 2, 2024 14:18
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2024-07-02 failed
5 participants