Set baseVersion to 3.6.0 instead of 3.6.0-RC1 #21011
Conversation
| @@ -88,7 +88,7 @@ object Build { | |||
|
|
|||
| val referenceVersion = "3.4.2-RC1" | |||
|
|
|||
| val baseVersion = "3.6.0-RC1" | |||
| val baseVersion = "3.6.0" | |||
There was a problem hiding this comment.
This change would break our current versioning of nightlies, which are defined using pattern <baseVersion>-bin-YYYYMMDD-<commitSHA>-NIGHTLY
In theory all nightlies are always -RC1 so there should be no conflicts with this one.
@Kordyjan any thoughts on that?
There was a problem hiding this comment.
we can always add the -RC1 at the beginning of the nightlies' pattern instead of relying on its presence in baseVersion if we must keep the same pattern :
Line 172 in 010ed5a
| @@ -169,9 +171,9 @@ object Build { | |||
| if (isRelease) | |||
| baseVersion | |||
| else if (isNightly) | |||
| baseVersion + "-bin-" + VersionUtil.commitDate + "-" + VersionUtil.gitHash + "-NIGHTLY" | |||
| baseVersion + "-RC1-bin-" + VersionUtil.commitDate + "-" + VersionUtil.gitHash + "-NIGHTLY" | |||
There was a problem hiding this comment.
| baseVersion + "-RC1-bin-" + VersionUtil.commitDate + "-" + VersionUtil.gitHash + "-NIGHTLY" | |
| prereleaseVersion + "-bin-" + VersionUtil.commitDate + "-" + VersionUtil.gitHash + "-NIGHTLY" |
There was a problem hiding this comment.
idk if this makes more sense
There was a problem hiding this comment.
@Kordyjan asked me to add this field for a future automation. I'm not sure what it is so I would rather not use it until then. To see if it makes sense to use it in a more general context.
| else | ||
| baseVersion + "-bin-SNAPSHOT" | ||
| baseVersion + "-RC1-bin-SNAPSHOT" |
There was a problem hiding this comment.
| baseVersion + "-RC1-bin-SNAPSHOT" | |
| prereleaseVersion + "-bin-SNAPSHOT" |
In #20547, to be able to build an msi installer, the version needs to have the following pattern
A.B.C.D.This change should be fine but the release procedure of RC1 will have to take it into account.