Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isomorphism tests of AndOrTypes under non-empty BinderPairs #21017

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Fix isomorphism tests of AndOrTypes under non-empty BinderPairs #21017

merged 2 commits into from
Jul 4, 2024

Commits on Jul 4, 2024

  1. Fix isomorphism tests of AndOrTypes under non-empty BinderPairs 

    Before the changes, when comparing two `HKTypeLambda` result types,
the list of binding pairs was lost when entering comparison of `AndOrType`s,
which caused the `equals` to fail, and hence prevented `hash-consing`.

Even though, `M1` and `M2` in pos/i20858-min should still conform to one-another,
we entered a deep-subtype comparison because of the order in which the TypeComparer
does dealiasing of AppliedTypes, comparison of MatchCases, and AndTypes.
    @EugeneFlesselle
    EugeneFlesselle committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    62544e8 View commit details
    Browse the repository at this point in the history

  2. Update compiler/src/dotty/tools/dotc/core/Types.scala

    @EugeneFlesselle
    EugeneFlesselle authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    21fc03f View commit details
    Browse the repository at this point in the history