Fix uninitializing fields when evaluating a cached constructor call in global initialization checker #21403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnzeXing
changed the title
liufengyun
approved these changes
Aug 20, 2024
| val b2 = new Bar() | ||
| val b3 = new Bar() | ||
| b3.f = 1 | ||
|
|
There was a problem hiding this comment.
Minor: trailing spaces in file.
| @@ -950,7 +950,6 @@ class Objects(using Context @constructorOnly): | |||
|
|
|||
| val instance = OfClass(klass, outerWidened, ctor, args.map(_.value), envWidened) | |||
| callConstructor(instance, ctor, args) | |||
There was a problem hiding this comment.
I'd add a comment above callConstructor and refer to the test. Something like the following:
// The actual instance might be cached without running the constructor.
// See tests/init-global/pos/cache-constructor.scala
olhotak
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the accessing uninitialized field errors given by the global initialization checker, where fields are uninitialized when evaluating a cached constructor call during the analysis.