Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimplePattern errors should now be recovered as wildcard instead of unimplemented expr #21438

Merged
merged 1 commit into from
Aug 26, 2024
Merged

SimplePattern errors should now be recovered as wildcard instead of unimplemented expr #21438

merged 1 commit into from
Aug 26, 2024

Conversation

rochala
Copy link
Contributor

@rochala rochala commented Aug 26, 2024

We should not emit more errors that came from our error recovery term trees.

Previously, we've recovered those situations with unimplemented expression term added in #19103
and before that it was just a null

@rochala rochala requested a review from odersky August 26, 2024 14:07
odersky
odersky approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rochala rochala merged commit f036195 into scala:main Aug 26, 2024
28 checks passed
WojciechMazur pushed a commit that referenced this pull request Aug 28, 2024
@rochala @WojciechMazur
SimplePattern errors should now be recovered as wildcard instead of u…
74cfecf 
…nimplemented expr (#21438)

We should not emit more errors that came from our error recovery term
trees.

Previously, we've recovered those situations with unimplemented
expression term added in #19103
and before that it was just a `null`
[Cherry-picked f036195]
@WojciechMazur WojciechMazur mentioned this pull request Aug 28, 2024
Merged
WojciechMazur added a commit that referenced this pull request Aug 28, 2024
@WojciechMazur
Backport "SimplePattern errors should now be recovered as wildcard in…
123ee63 
…stead of unimplemented expr" to 3.5.2 (#21498)

Backports #21438 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]
@rochala rochala mentioned this pull request Aug 28, 2024
Merged
2 tasks
@WojciechMazur WojciechMazur added this to the 3.5.2 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rochala @odersky @WojciechMazur