Fix typo in extension method example

[eloots]

• Remove an extraneous ‘.’ in example code

[dottybot]

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

[eloots]

Apparently, I hadn't signed the Scala CLA (as I wrongly assumed it was covered by another CLA I signed before).
Fixed now.

[biboudis]

Just noticed that the same exists in

https://dotty.epfl.ch/docs/reference/contextual/extension-methods-new.html

According to this:

#7914
which was superseded by
#7917

the dot syntax is valid. It is also documented in

DefSig            ::=  id [DefTypeParamClause] DefParamClauses
                    |  ExtParamClause [nl] [‘.’] id DefParamClauses

https://dotty.epfl.ch/docs/internals/syntax.html

Should we swap the two pages? @smarter ?

[eloots]

@biboudis Indeed.

docs/docs/reference/contextual/extension-methods-new.md contains the same typo in the first example, so I've added the correction to this file to this PR too.

I presume the plan is to swap docs/docs/reference/contextual/extension-methods.md for docs/docs/reference/contextual/extension-methods-new.md when 0.22.0-RC1 is released.

[biboudis]

The dot-syntax is valid so we shouldn't remove it, so lets keep the parenthesis typo only and I merge

Check: 9a0ddcd

[Blaisorblade]

@biboudis No, one of those dots is a syntax error, because https://dotty.epfl.ch/docs/reference/contextual/extension-methods.html is meant to be about 0.21.0-RC1.

$ dotr -version
Starting dotty REPL...
Dotty compiler version 0.21.0-RC1 -- Copyright 2002-2019, LAMP/EPFL
scala> case class Circle(x: Double, y: Double, radius: Double)
// defined case class Circle

scala> def (c: Circle).circumference: Double = c.radius * math.Pi * 2
1 |def (c: Circle).circumference: Double = c.radius * math.Pi * 2
  |               ^
  |               an identifier expected, but '.' found
1 |def (c: Circle).circumference: Double = c.radius * math.Pi * 2
  |                                                              ^
  |                                               '=' expected, but eof found

scala> def (c: Circle) circumference: Double = c.radius * math.Pi * 2
def circumference(c: Circle): Double

scala>

[Blaisorblade]

@eloots I took the liberty of editing the PR to show what it should be, IIUC.
EDIT: feel absolutely free to edit further/squash/...

[Blaisorblade]

FWIW, the current docs workflow seems very challenging to deal with: Docs in master must document both the latest release and the current master. In many other projects, each version contains its own docs, and the website has a different folder for each release.

[biboudis]

Thx both! @Blaisorblade

[eloots]

@Blaisorblade

FWIW, the current docs workflow seems very challenging to deal with: Docs in master must document both the latest release and the current master. In many other projects, each version contains its own docs, and the website has a different folder for each release.

Couldn't agree more. It's quite confusing. I now look at the ref docs on the latest RC1 and the latest version on master (by pulling the most recent state on master & running genDocs)