Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch Onnxruntime, Sortednp, and DracoPy #4

Merged
merged 34 commits into from
Oct 24, 2024
Merged

Patch Onnxruntime, Sortednp, and DracoPy #4

merged 34 commits into from
Oct 24, 2024

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Aug 8, 2024 •
edited by Tobias314
Loading

THis PR includes two major changes

  • Continuation of PR Patch libs for numpy 2.0 #3 to patch DracoPy and sortednp with numpy 2 support.
  • Re-Compile onnxruntime for Linux with glibc version 2.12 to use on the out-dated Gaba environments

@Tobias314 Tobias314 marked this pull request as ready for review August 27, 2024 13:11
@hotzenklotz hotzenklotz changed the title Patch DracoPy Patch Onnxruntime Oct 24, 2024
@hotzenklotz hotzenklotz added the enhancement New feature or request label Oct 24, 2024
@hotzenklotz
Copy link
Member Author

@Tobias314 Can you please have a look at this PR, especially the DracoPystuff. I am not sure what the difference to main are and if we should merge them. Maybe we have to separate them from onnx changes.

The changes to onnxruntime are fine and can be merged.

@hotzenklotz hotzenklotz self-assigned this Oct 24, 2024
@Tobias314 Tobias314 changed the title Patch Onnxruntime Patch Onnxruntime, Sortednp, and DracoPy Oct 24, 2024
Tobias314
Tobias314 reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@Tobias314 Tobias314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the DracoPy changes are just our changes to make it work with numpy 2.0.
The DracoPy action seems to run through, so I would just assume it does what it should do and merge it. :)

@Tobias314 Tobias314 merged commit 9cc210b into main Oct 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobias314 Tobias314 Tobias314 left review comments

Assignees

@hotzenklotz hotzenklotz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotzenklotz @Tobias314