Add Scala 3 support #101
Open
Add Scala 3 support #101
+37
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
Oct 5, 2024
| with CommonPublish | ||
| with CommonPublish { | ||
|
|
||
| // note: somehow, this doesn't work (causes "Please override mimaPreviousVersions or mimaPreviousArtifacts") |
There was a problem hiding this comment.
thought: I didn't spend too much time on it, hoping someone with more Mill experience can provide a better understanding and maybe a proper fix. This seems like something that only affects us until we publish the 3.x support.
kubukoz
commented
Oct 5, 2024
| @@ -0,0 +1,3 @@ | |||
| package bloop.config | |||
|
|
|||
| trait SourceGeneratorCompanionPlatform {} | |||
There was a problem hiding this comment.
thought: extends AbstractFunction3 was causing a "missing apply method" in Scala 3. Adding that apply was conflicting with the other apply - hence, version-specific sources.
tgodzik
requested changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock Bloop's ability to cross-build sbt-bloop for sbt 2.0 (sbt/sbt#7698).