refactor: remove publishing for 2.11 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this doesn't mean you can't use Bloop with 2.11, it just means that an application using 2.11 can't use the config library anymore to generate the config. Seeing that everything I know of is probably on 2.13, I think we're pretty safe to drop 2.11. It'd be nice to also add in Scala 3, but we use too old of a jsoniter version for this. We're locked on an older version to support Java 8. However, I'm assuming we'll change that soon as well, and then we can bump this and cross publish to 3 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this doesn't mean you can't use Bloop with 2.11, it just means
that an application using 2.11 can't use the config library anymore to
generate the config. Seeing that everything I know of is probably on
2.13, I think we're pretty safe to drop 2.11. It'd be nice to also add
in Scala 3, but we use too old of a jsoniter version for this. We're
locked on an older version to support Java 8. However, I'm assuming
we'll change that soon as well, and then we can bump this and cross
publish to 3 as well.
Also for context what made me look into this is that the new mill-scalafix
wasn't working with 2.11 anymore.