Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mill-crossplatform in build.sc #6

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Use mill-crossplatform in build.sc #6

merged 1 commit into from
Nov 29, 2022

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Nov 25, 2022

No description provided.

@ckipp01
Copy link
Member

ckipp01 commented Nov 25, 2022 •
edited
Loading

Ooooo, 👀 .

Also I make some changes in #5 that you'll want to take into account. So it might be worth putting this on top of that pr. Ignore that, don't rebase it that was wrong.

@ckipp01 ckipp01 marked this pull request as ready for review November 29, 2022 07:33
ckipp01
ckipp01 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in @lolgab! I went ahead and fixed the conflicts since I made some changes since you sent this in. I like how much this reduces the boilerplate. Let's give this a try! I'll report on any issues if I hit on them!

@ckipp01 ckipp01 merged commit 789363e into scalacenter:main Nov 29, 2022
@lolgab lolgab deleted the try-mill-crossplatform branch November 29, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lolgab @ckipp01