Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add unamanaged outputs so that we can check script itself #95

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jul 29, 2024

Build tools might want to also hash the script used for source generation in case it changes. In that case they can keep the entry for the script in unmanagedOutputs.

Build tools might want to also hash the script used for source generation in case it changes. In that case they can keep the entry for the script in unmanagedOutputs.
@bishabosha
Copy link
Member

I'm unfamiliar with this codebase, is this the only change necessary in this repo? like I assume all the caching logic is in the bloop repo

@tgodzik
Copy link
Contributor Author

tgodzik commented Jul 29, 2024

I'm unfamiliar with this codebase, is this the only change necessary in this repo? like I assume all the caching logic is in the bloop repo

The caching logic yes, but the configuration for Bloop needs to be somehow provided and that is done via the classes here. I will need to follow up with a PR to Bloop for the actual implementation of the logic.

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, seems generic enough for me

@tgodzik tgodzik merged commit ce23d89 into main Jul 30, 2024
4 checks passed
@tgodzik tgodzik deleted the add-unmanaged branch July 30, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants