bugfix: Named args completions with default values

scalameta · Sep 18, 2023 · 9783cde · 9783cde
1 parent d7be734
commit 9783cde
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 2 deletions.
diff --git a/mtags/src/main/scala-3/scala/meta/internal/pc/completions/NamedArgCompletions.scala b/mtags/src/main/scala-3/scala/meta/internal/pc/completions/NamedArgCompletions.scala
@@ -243,8 +243,9 @@ object NamedArgCompletions:
         .filterNot {
           case (arg, _) if arg.symbol.denot.is(Flags.Synthetic) => true
           case (Ident(name), _) => name.is(DefaultGetterName) // default args
-          case (Select(Ident(_), name), _) =>
-            name.is(DefaultGetterName) // default args for apply method
+          case (Select(_, name), _) =>
+            // default args for methods defined in object
+            name.is(DefaultGetterName)
           case _ => false
         }
         .map {

diff --git a/tests/cross/src/test/scala/tests/pc/CompletionArgSuite.scala b/tests/cross/src/test/scala/tests/pc/CompletionArgSuite.scala
@@ -244,6 +244,40 @@ class CompletionArgSuite extends BaseCompletionSuite {
     "",
   )
 
+  check(
+    "default-args",
+    """|object Main {
+       |  def foo() = {
+       |    def deployment(
+       |      arg1: String,
+       |      arg2: Int = 1,
+       |    ): Option[Int] = ???
+       |    val abc = deployment(@@)
+       |  }
+       |}
+       |""".stripMargin,
+    """|arg1 = : String
+       |arg2 = : Int
+       |""".stripMargin,
+    topLines = Some(2),
+  )
+
+  check(
+    "default-args2",
+    """|object Main {
+       |  def deployment(
+       |    arg1: String,
+       |    arg2: Int = 1,
+       |  ): Option[Int] = ???
+       |  val abc = deployment(@@)
+       |}
+       |""".stripMargin,
+    """|arg1 = : String
+       |arg2 = : Int
+       |""".stripMargin,
+    topLines = Some(2),
+  )
+
   checkSnippet( // see: https://github.com/scalameta/metals/issues/2400
     "explicit-dollar",
     """