Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.1 breaks listener notifications for skipped suites #813

Open
nikita-tkachenko-datadog opened this issue Aug 20, 2024 · 1 comment

Comments

@nikita-tkachenko-datadog

The way notifications work is changed in this PR.

In versions up to and including v1.0.0 a custom RunListener implementation receives the following notifications when a suite is skipped:

  • org.junit.runner.notification.RunListener#testSuiteStarted
  • org.junit.runner.notification.RunListener#testIgnored
  • org.junit.runner.notification.RunListener#testSuiteFinished

With the PR referenced above only the org.junit.runner.notification.RunListener#testIgnored notification is fired for such suites.

@tgodzik
Copy link
Contributor

tgodzik commented Aug 26, 2024

Thanks for reporting! We should probably rework this to still send notification, but not print them. 🤔

I will not have time to work on that anytime soon, so any contributions would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants