Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print test suite name if no test is being run #779

Merged
merged 1 commit into from
May 23, 2024

Conversation

alexarchambault
Copy link
Contributor

These changes make munit print only the test suite names of suites for which it actually ran tests, rather than printing all suite names (even those for which all tests are being filtered out), as it's been doing up to now.

For example, instead of printing things like

$ ./mill -i -w scala.integration.test "almond.integration.KernelTestsSimple3.completion"
…
almond.integration.KernelTestsSimple3:
  + completion 17.073s
almond.integration.KernelTestsTwoStepStartup3:
almond.integration.KernelTestsSimple213:
almond.integration.KernelTestsTwoStepStartup212:
almond.integration.KernelTestsTwoStepStartup213:
almond.integration.KernelTestsSimple212:

it now prints

$ ./mill -i -w scala.integration.test "almond.integration.KernelTestsSimple3.completion"
…
almond.integration.KernelTestsSimple3:
  + completion 15.468s

I find the latter to be more readable.

@alexarchambault
Copy link
Contributor Author

Not sure how to test that, or if it needs to be tested. (Going to see if it break things on the CI here…)

Manual tests show that it works as expected, at least.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though I wonder if there was no initial purpose for printing thise? @valencik @mzuehlke any opinions here?

Copy link
Contributor

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the output of individual tests that are ignored or skipped more verbose in #766.
But for complete suites I find your change good.👍🏻
What are scalatest or junit doing in these cases?

@tgodzik tgodzik merged commit 472dfe8 into scalameta:main May 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants