Feature: a one-liner version of newlines.alwaysBeforeElseAfterCurlyIf=true

[kitbellew]

This template is a guideline, not a strict requirement.

• Version: 1.2.0
• Integration: CLI
• Configuration:

style = default
maxColumn = 100
danglingParentheses = true

align = none
align.tokens = []
align.openParenCallSite = false

newlines.alwaysBeforeTopLevelStatements = true
newlines.sometimesBeforeColonInMethodReturnType = false
newlines.alwaysBeforeCurlyBraceLambdaParams = true
newlines.afterImplicitKWInVerticalMultiline = true
newlines.beforeImplicitKWInVerticalMultiline = true

runner.fatalWarnings = true
runner.optimizer.forceConfigStyleOnOffset = 50
runner.optimizer.forceConfigStyleMinArgCount = 5

rewrite.rules = [ExpandImportSelectors, PreferCurlyFors]

Steps

I ran scalafmt like this:

scalafmt

Problem

Input is

      if ('0' <= ch && ch <= '9') { ch - '0' }
      else if ('A' <= ch && ch <= 'F') { ch - 'A' + 10 }
      else if ('a' <= ch && ch <= 'f') { ch - 'a' + 10 }
      else { -1 }

Scalafmt formats code like this:

      if ('0' <= ch && ch <= '9') { ch - '0' } else if ('A' <= ch && ch <= 'F') { ch - 'A' + 10 } else if ('a' <= ch && ch <= 'f') {
        ch - 'a' + 10
      } else { -1 }

Expectation

I would like the formatted output to look either exactly like the input, or like this:

      if ('0' <= ch && ch <= '9') {
        ch - '0'
      } else if ('A' <= ch && ch <= 'F') {
        ch - 'A' + 10
      } else if ('a' <= ch && ch <= 'f') {
        ch - 'a' + 10
      } else {
        -1
      }

but definitely not the way it was chosen.

[olafurpg]

Thanks for reporting! This is a duplicate of #271, I agree the formatted output is not good.

Note that when given

    if ('0' <= ch && ch <= '9') {
        ch - '0'
      } else if ('A' <= ch && ch <= 'F') {
        ch - 'A' + 10
      } else if ('a' <= ch && ch <= 'f') {
        ch - 'a' + 10
      } else {
        -1
      }

Scalafmt leaves the code unchanged.

[olafurpg]

FYI I opened #1180 forcing a line break for if/else bodies that are blocks so that the formatted output matches expected output in this ticket. No need to manually insert line breaks :)