You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<<< slick groupBy 2defgroupBy[K, T, G, P](f: E=>K)(implicitkshape: Shape[_ <:FlatShapeLevel, K, T, G], vshape: Shape[_ <:FlatShapeLevel, E, _, P]):Query[(G, Query[P, U, Seq]), (T, Query[P, U, Seq]), C, (T, Query[P, U, Seq]), (T, Query[P, U, Seq])]
Scalafmt:
defgroupBy[K, T, G, P](f: E=>K)(
implicitkshape: Shape[_ <:FlatShapeLevel, K, T, G],
vshape: Shape[_ <:FlatShapeLevel, E, _, P])
:Query[(G, Query[P, U, Seq]),
(T, Query[P, U, Seq]),
C,
(T, Query[P, U, Seq]),
(T, Query[P, U, Seq])]
Note the newline before : Query[.... That newline previously came before the closing parenthesis ): Query[.... I suspect @sjrd will never approve this. So my suggestion is to add a configuration flag --allowNewlineBeforeColonInMassiveReturnTypes that's set to true in the default style and false in scalaJs.
Any objections?
The text was updated successfully, but these errors were encountered:
In order to fix #192 I need to come up with a better solution for massive return types. The solution I've come up with is to follow the Spark style guide: https://github.com/databricks/scala-style-guide#indent
Original:
Scalafmt:
Note the newline before
: Query[...
. That newline previously came before the closing parenthesis): Query[...
. I suspect @sjrd will never approve this. So my suggestion is to add a configuration flag--allowNewlineBeforeColonInMassiveReturnTypes
that's set to true in the default style and false in scalaJs.Any objections?
The text was updated successfully, but these errors were encountered: