#1627 [04]: Router: ignore line breaks in if-else and bodies #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poslegm
reviewed
Mar 11, 2020
| @@ -1359,10 +1376,13 @@ class Router(formatOps: FormatOps) { | |||
| case x => throw new UnexpectedTree[Term.If](x) | |||
| }) => | |||
| val expire = leftOwner.asInstanceOf[Term.If].elsep.tokens.last | |||
| val noSpace = style.newlines.source match { | |||
There was a problem hiding this comment.
3-times repeated noSpace computation? May be extract it to a function?
poslegm
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify breaks around control expressions (
if-else,for,whileetc.) and their bodies.Helps with #1627.
scala-reposdiffs:classicandkeep: unchangedfold: kitbellew/scala-repos@50420e5?w=1unfold: kitbellew/scala-repos@f3e2e42?w=1