#1627 [06]: Router: ignore line breaks for config style apply #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poslegm
reviewed
Mar 17, 2020
| case EndpointActivated(`endpoint`) ⇒ endpoint | ||
| case EndpointFailedToActivate(`endpoint`, cause) ⇒ throw cause | ||
| }) | ||
| <<< SKIP 3.27 enclosed in block, def, chain follows |
There was a problem hiding this comment.
Are you planning to remove SKIP in the next PRs before release?
There was a problem hiding this comment.
yes, it needs a matching change handling unfold in select chains
poslegm
approved these changes
Mar 17, 2020
1. reduce indent to 2 and de-indent earlier in binPack.unsafeCallSite 2. anticipate dangle when comment/NL precede closing paren 3. in infix with parens, recognize newline after single-line comment and set correct indent and dangle
The original naming reflected the side of FormatToken which will be used to find the expiration token but it conflicted with the two more common types deriving from util.Either and was not intuitive to use.
For the purposes of this change, config style would mean a newline after the opening parenthesis and one argument per line. Whether the closing parenthesis is dangling can be controlled via the danglingParentheses parameter. NB: there are other places where config style is checked, they will be addressed separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the purposes of this change, config style would mean a newline after the opening parenthesis and one argument per line. Whether the closing parenthesis is dangling can be controlled via the danglingParentheses parameter.
NB: there might be other places where config style is checked, they will be addressed separately.
Helps with #1627.